Skip to content

refactor(toolset): remove orphaned code-search toolset methods#52

Merged
barredterra merged 1 commit into
developfrom
cleanup-orphaned-code-search-methods
Jul 13, 2026
Merged

refactor(toolset): remove orphaned code-search toolset methods#52
barredterra merged 1 commit into
developfrom
cleanup-orphaned-code-search-methods

Conversation

@barredterra

Copy link
Copy Markdown
Member

Summary

  • Drop the five ask_alyfToolset wrapper methods search_code, read_code_file, ls, find, and grep. After the move to the Deep Agents source-code-analyzer subagent, code search runs against the /source/ virtual mount and these wrappers were no longer registered as agent tools and had no callers.
  • The underlying tools.* functions remain, still used by tests and the VFS backend.

Context

Follow-up cleanup that was intended to ride on the previous deepagent-fixes PR but landed on the backport branches after that PR had already merged. This PR brings develop to parity with the version-15 / version-16 backport branches.

Test plan

  • Edited file parses; no linter errors.
  • Module imports cleanly; the five methods are gone.
  • Full code-tools test module passes (34 tests), including the assertions that these tool names are absent from the parent tool list.

Drop the five ask_alyfToolset wrappers search_code, read_code_file,
ls, find, and grep. Code search now runs through the source-code-analyzer
subagent against the /source/ virtual mount, so these wrappers were no
longer registered as agent tools and had no callers. The underlying
tools.* functions remain, still used by tests and the VFS backend.
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — removes only dead wrapper methods with no remaining call-sites in the codebase.

The deletion is a pure subtraction of five methods that had already lost their registration as agent tools. No callers remain on ask_alyfToolset instances, the underlying tools.* functions are untouched, and the existing test suite explicitly asserts that these tool names are absent from the parent tool list, so the tests directly validate the intended post-state.

No files require special attention.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Agent as LLM Agent
    participant Runner as ask_alyfAgentRunner
    participant Subagent as source-code-analyzer subagent
    participant Tools as tools.* (VFS backend)

    Note over Agent,Tools: Before this PR (now removed)
    Agent->>Runner: call search_code / ls / find / grep / read_code_file
    Runner->>Tools: tools.search_code() etc.
    Tools-->>Runner: result
    Runner-->>Agent: result

    Note over Agent,Tools: After this PR (current state)
    Agent->>Runner: _build_subagents()
    Runner->>Subagent: register source-code-analyzer
    Agent->>Subagent: code search request (via /source/ VFS)
    Subagent->>Tools: tools.search_code() etc.
    Tools-->>Subagent: result
    Subagent-->>Agent: result
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Agent as LLM Agent
    participant Runner as ask_alyfAgentRunner
    participant Subagent as source-code-analyzer subagent
    participant Tools as tools.* (VFS backend)

    Note over Agent,Tools: Before this PR (now removed)
    Agent->>Runner: call search_code / ls / find / grep / read_code_file
    Runner->>Tools: tools.search_code() etc.
    Tools-->>Runner: result
    Runner-->>Agent: result

    Note over Agent,Tools: After this PR (current state)
    Agent->>Runner: _build_subagents()
    Runner->>Subagent: register source-code-analyzer
    Agent->>Subagent: code search request (via /source/ VFS)
    Subagent->>Tools: tools.search_code() etc.
    Tools-->>Subagent: result
    Subagent-->>Agent: result
Loading

Reviews (1): Last reviewed commit: "refactor(toolset): remove orphaned code-..." | Re-trigger Greptile

@barredterra
barredterra merged commit 4750f37 into develop Jul 13, 2026
5 checks passed
@barredterra
barredterra deleted the cleanup-orphaned-code-search-methods branch July 13, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant