Skip to content

fix: handle case-sensitive export.xml#41

Open
aozsyn wants to merge 1 commit into
alxdrcirilo:mainfrom
aozsyn:bug/40-case-sensitive-handling
Open

fix: handle case-sensitive export.xml#41
aozsyn wants to merge 1 commit into
alxdrcirilo:mainfrom
aozsyn:bug/40-case-sensitive-handling

Conversation

@aozsyn

@aozsyn aozsyn commented Jul 6, 2026

Copy link
Copy Markdown

in re bug #40

@alxdrcirilo alxdrcirilo changed the title handle case-sensitive export.xml fix: handle case-sensitive export.xml Jul 12, 2026
@alxdrcirilo

Copy link
Copy Markdown
Owner

Hey!

Thanks for making a PR. So I tried this locally but it won't work. That's because the implementation has a small bug: Path.resolve() never raises FileNotFoundError. By default it uses strict=False, so it just returns an absolute path regardless of whether the file exists or not.

I think it would be better to use Path.exists() instead (and fallback to the capitalised Export.xml when export.xml does not exist). Maybe something like this?

path = export_dir / "export.xml"
if not path.exists():
    path = export_dir / "Export.xml"

return path.resolve()

Do you also have some time to add a test for this? If you'd like to do the entire PR by yourself, that's fine too. And if you'd like me to make a test, that's equally fine by me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants