Point source-repository head at main - #267
Draft
alunduil wants to merge 1 commit into
Draft
Conversation
The stanza still named develop, which #82 renamed to main and retired. The value is not inert: it ships in the sdist, renders on the Hackage page, and drives cabal get -s, which fails today against the published 1.3.1.3 with "fatal: Remote branch develop not found in upstream origin". Landing this before the 1.3.2.0 tag makes that release the upload that fixes the pointer rather than the second one carrying it broken. Closes #266 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013U3Mvn9yPinG1dRj8p5DEv
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 1 1
Lines 142 142
Branches 27 27
=======================================
Hits 110 110
Misses 5 5
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One line:
source-repository headincollection-json.cabalnameddevelop,which #82 renamed to
mainand retired. Now namesmain.Closes #266.
Gotchas
The reason this is worth a PR of its own rather than a drive-by in the release
commit: the stanza is not inert metadata. It ships in the sdist, renders on the
Hackage page, and is what
cabal get -sclones. Against the currently publishedversion it fails outright:
The published 1.3.1.3 cabal file carries the same
branch: develop, so thisbroke when the branch was renamed rather than at any upload — it is live on
Hackage today, not a prospective problem.
Sequenced ahead of the 1.3.2.0 tag (#84) so that release is the upload that
fixes the pointer instead of the second one shipping it broken.
Verification
cabal check— no errors or warnings.git ls-remote --heads https://github.com/alunduil/collection-json.hs mainresolves, so the branch the stanza now names exists.
collection-json.cabalcarriesbranch: main— the fix reaches the artifact, not just the working tree.pre-commit run --files collection-json.cabalpasses.cabal get -sitself can only be exercised post-publish, so the ls-remote andsdist checks stand in for it until 1.3.2.0 is up.
🤖 Generated with Claude Code
https://claude.ai/code/session_013U3Mvn9yPinG1dRj8p5DEv