test: first attempt with JSON specifications for transactions#3
Merged
Merged
Conversation
… read preference within a transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings
cryomongointo 100% compliance with the official MongoDBtransactionsandtransactions-convenient-apispecifications.Session::ClientSession#with_transactionto implement the specification's strict exponential backoff, jitter, and 120-second fallback timeouts.socket_timeoutandconnect_timeoutconfigurations were parsed but never actually applied to the underlyingTCPSocket/UNIXSocket.Sessionentities,assertSessionPinned,assertSessionTransactionState, and automatically routesfailCommandfailpoints correctly to theadmindatabase.amebadependency, ensuring our CI and local environments can upgrade smoothly to the latest Crystal releases.Test Coverage: 324/324 Unified Tests Passing
(Note: The test suite now takes ~18 minutes to complete as it needs to execute physical blocking, connection drops, and backoff sleeps demanded by the transaction specification.)