Skip to content

chore: expand TypedCondition on Query with FieldDescriptor, for auxiliary data for adapters #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulocoghi merged 1 commit into from
Jul 10, 2026
Merged

chore: expand TypedCondition on Query with FieldDescriptor, for auxiliary data for adapters #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/service/query.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module Alumna
end

# 2. Coerced condition holding native Crystal types
record TypedCondition, op : Op, value : AnyData
record TypedCondition, op : Op, value : AnyData, fd : FieldDescriptor?

getter filters : Hash(String, Array(Condition))
getter limit : Int32?
Expand Down Expand Up @@ -101,13 +101,13 @@ module Alumna
return ServiceError.bad_request("Invalid type for query parameter #{key}") if cast_val.nil?
arr << cast_val
end
res[key] << TypedCondition.new(c.op, arr.as(AnyData))
res[key] << TypedCondition.new(c.op, arr.as(AnyData), fd)
else
raw_val = cv.is_a?(Array(String)) ? cv.first : cv
cast_val = cast_value(raw_val, type, fd)

return ServiceError.bad_request("Invalid type for query parameter #{key}") if cast_val.nil?
res[key] << TypedCondition.new(c.op, cast_val)
res[key] << TypedCondition.new(c.op, cast_val, fd)
end
end
end
Expand Down
Loading