Skip to content

fix: truncated message with emoji#541

Closed
ColonelBucket8 wants to merge 1 commit into
altsem:masterfrom
ColonelBucket8:fix/log-message-truncated-with-emoji
Closed

fix: truncated message with emoji#541
ColonelBucket8 wants to merge 1 commit into
altsem:masterfrom
ColonelBucket8:fix/log-message-truncated-with-emoji

Conversation

@ColonelBucket8

Copy link
Copy Markdown
Contributor

Fixes #495

  • Switch to UnicodeWidthStr::width; truncation now walks
    graphemes accumulating cell width with 1-cell ellipsis reservation in
    cell units.
  • Move unicode-width from [dev-dependencies] to
    [dependencies].

Checklist

  • The modified code has some test-coverage (where applicable).
  • make test is passing (this is what CI runs).
  • New unreleased features/fixes/styling and performance improvements are documented via git: feat: / fix: / style: / perf:. Or e.g. perf(highlighting):.
    See https://github.com/altsem/gitu/blob/master/docs/dev-tooling.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log message truncated with containing emoji/unicode

1 participant