Skip to content

fix(privacy): stop persisting dictated content to the disk log #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
postoso wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(privacy): stop persisting dictated content to the disk log #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01eb3f2
fix(privacy): stop persisting dictated content to the disk log
postoso Jun 23, 2026
c89b16d
test(privacy): assert dictated content is not written to the disk log
postoso Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions Sources/Fluid/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,7 +1972,7 @@ struct ContentView: View {

// If this was a rewrite recording, process the rewrite instead of typing
if wasRewriteMode {
DebugLogger.shared.info("Processing rewrite with instruction: \(transcribedText)", source: "ContentView")
DebugLogger.shared.info("Processing rewrite (instruction chars: \(transcribedText.count))", source: "ContentView")
let appInfo = self.recordingAppInfo ?? self.getCurrentAppInfo()
await self.processRewriteWithVoiceInstruction(transcribedText, appInfo: appInfo)
AnalyticsService.shared.capture(
Expand All @@ -1988,7 +1988,7 @@ struct ContentView: View {

// If this was a command recording, process the command
if wasCommandMode {
DebugLogger.shared.info("Processing command: \(transcribedText)", source: "ContentView")
DebugLogger.shared.info("Processing command (chars: \(transcribedText.count))", source: "ContentView")
await self.processCommandWithVoice(transcribedText)
AnalyticsService.shared.capture(
.transcriptionCompleted,
Expand Down Expand Up @@ -2517,7 +2517,7 @@ struct ContentView: View {
) async {
self.rewriteModeService.setPromptAppBundleID(appInfo.bundleId)
let hasOriginalText = !self.rewriteModeService.originalText.isEmpty
DebugLogger.shared.info("Processing \(hasOriginalText ? "rewrite" : "write/improve") - instruction: '\(instruction)', originalText length: \(self.rewriteModeService.originalText.count)", source: "ContentView")
DebugLogger.shared.info("Processing \(hasOriginalText ? "rewrite" : "write/improve") - instruction chars: \(instruction.count), originalText length: \(self.rewriteModeService.originalText.count)", source: "ContentView")

// Show processing animation
self.menuBarManager.setProcessing(true)
Expand Down Expand Up @@ -2666,7 +2666,7 @@ struct ContentView: View {
// MARK: - Command Mode Voice Processing

private func processCommandWithVoice(_ command: String) async {
DebugLogger.shared.info("Processing voice command: '\(command)'", source: "ContentView")
DebugLogger.shared.info("Processing voice command (chars: \(command.count))", source: "ContentView")

// Show processing animation
self.menuBarManager.setProcessing(true)
Expand Down Expand Up @@ -3185,11 +3185,17 @@ extension ContentView {
}

private func logDictationPromptTrace(_ title: String, value: String) {
let line = "[PromptTrace][Dictate] \(title):\n\(value)"
// Privacy: prompt-trace values are raw user content (the dictated transcript, the
// folded prompt, the model's answer and thinking). DebugLogger persists every line to
// a plaintext disk log (~/Library/Logs/Fluid/Fluid.log), and this trace is enabled
// whenever EnableDebugLogs is on (the default), so the raw value must never be routed
// there. The full trace remains available on the console for live debugging, gated
// behind the explicit FLUID_PROMPT_TRACE=1 env var; only a redacted metadata line is
// persisted to the log.
if self.forcePromptTraceToConsole {
print(line)
print("[PromptTrace][Dictate] \(title):\n\(value)")
}
DebugLogger.shared.debug(line, source: "ContentView")
DebugLogger.shared.debug("[PromptTrace][Dictate] \(title) (\(value.count) chars) [REDACTED]", source: "ContentView")
}

private func customPromptAnalyticsProperties(promptSource: String, overrideEmpty: Bool?) -> [String: Any] {
Expand Down
4 changes: 3 additions & 1 deletion Sources/Fluid/Networking/AIProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ final class OpenAICompatibleProvider: AIProvider {

if let http = response as? HTTPURLResponse, http.statusCode >= 400 {
let errText = String(data: data, encoding: .utf8) ?? "Unknown error"
DebugLogger.shared.error("AI API error HTTP \(http.statusCode): \(errText)", source: "AIProvider")
// Privacy: do not persist the error body (it can echo the request/prompt) — log
// status and body size only. The full text is still returned to the caller.
DebugLogger.shared.error("AI API error HTTP \(http.statusCode): \(data.count) bytes", source: "AIProvider")
return "Error: HTTP \(http.statusCode): \(errText)"
}
let decoded = try JSONDecoder().decode(ChatResponse.self, from: data)
Expand Down
28 changes: 17 additions & 11 deletions Sources/Fluid/Networking/FunctionCallingProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,10 @@ final class FunctionCallingProvider {
return .error("Failed to encode request")
}

// Debug: Log request payload
if let requestString = String(data: jsonData, encoding: .utf8) {
DebugLogger.shared.debug("Request JSON: \(requestString)", source: "FunctionCallingProvider")
}
// Debug: Log request metadata. Privacy: the request body embeds the user's dictated
// transcript / prompt, and DebugLogger persists to a plaintext disk log, so log only
// the body size, never its contents.
DebugLogger.shared.debug("Request JSON: \(jsonData.count) bytes", source: "FunctionCallingProvider")

var request = URLRequest(url: url)
request.httpMethod = "POST"
Expand All @@ -254,14 +254,16 @@ final class FunctionCallingProvider {
do {
let (data, response) = try await URLSession.shared.data(for: request)

// Log response
if let responseString = String(data: data, encoding: .utf8) {
DebugLogger.shared.debug("📥 LLM Response: \(responseString)", source: "FunctionCallingProvider")
}
// Log response metadata. Privacy: the response body is the model's reply derived
// from the user's dictation, and DebugLogger persists to a plaintext disk log, so
// log only its size, never the contents.
DebugLogger.shared.debug("📥 LLM Response: \(data.count) bytes", source: "FunctionCallingProvider")

if let http = response as? HTTPURLResponse, http.statusCode >= 400 {
let errText = String(data: data, encoding: .utf8) ?? "Unknown error"
DebugLogger.shared.error("HTTP \(http.statusCode): \(errText)", source: "FunctionCallingProvider")
// Privacy: do not persist the error body (it can echo the request/prompt) — log
// status and body size only. The full text is still returned to the caller.
DebugLogger.shared.error("HTTP \(http.statusCode): \(data.count) bytes", source: "FunctionCallingProvider")
return .error("HTTP \(http.statusCode): \(errText)")
}

Expand All @@ -283,8 +285,10 @@ final class FunctionCallingProvider {
var parsedCalls: [(name: String, arguments: [String: Any], callId: String)] = []

for toolCall in toolCalls {
// Privacy: tool-call arguments are model-generated from the user's dictation
// and may contain user content; log the tool name and argument size only.
DebugLogger.shared.info(
" → \(toolCall.function.name)(\(toolCall.function.arguments))",
" → \(toolCall.function.name)(\(toolCall.function.arguments.count) chars)",
source: "FunctionCallingProvider"
)
// Parse arguments JSON string
Expand Down Expand Up @@ -381,8 +385,10 @@ final class FunctionCallingProvider {

if let http = response as? HTTPURLResponse, http.statusCode >= 400 {
let errText = String(data: data, encoding: .utf8) ?? "Unknown error"
// Privacy: do not persist the error body (it can echo the request/prompt) — log
// status and body size only. The full text is still returned to the caller.
DebugLogger.shared.error(
"HTTP \(http.statusCode) in continueWithToolResults: \(errText)",
"HTTP \(http.statusCode) in continueWithToolResults: \(data.count) bytes",
source: "FunctionCallingProvider"
)
return .error("HTTP \(http.statusCode): \(errText)")
Expand Down
14 changes: 10 additions & 4 deletions Sources/Fluid/Services/ASRService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,9 @@ final class ASRService: ObservableObject {
guard let hit = hits.first else { return }
if hit != self.lastBoostHitTerm {
self.lastBoostHitTerm = hit
DebugLogger.shared.info("BOOST_HIT: '\(hit)'", source: "ASRService")
// Privacy: hit is a word from the user's transcript; log only that a boosted term
// was detected (with its length), never the term itself.
DebugLogger.shared.info("BOOST_HIT detected (\(hit.count) chars)", source: "ASRService")
}
self.refreshWordBoostStatus()
}
Expand Down Expand Up @@ -1092,8 +1094,10 @@ final class ASRService: ObservableObject {
let finalAudioSeconds = Double(pcm.count) / 16_000.0
let finalRTF = finalAudioSeconds > 0 ? (Double(finalElapsedMs) / 1000.0) / finalAudioSeconds : 0
DebugLogger.shared.debug("stop(): final transcription finished source=\(finalSource)", source: "ASRService")
// Privacy: result.text is the user's dictated transcript; DebugLogger persists to a
// plaintext disk log, so log only its length and confidence, never the text itself.
DebugLogger.shared.debug(
"Transcription completed: '\(result.text)' (confidence: \(result.confidence))",
"Transcription completed: \(result.text.count) chars (confidence: \(result.confidence))",
source: "ASRService"
)
DebugLogger.shared.info(
Expand All @@ -1117,7 +1121,8 @@ final class ASRService: ObservableObject {
// Do not update self.finalText here to avoid instant binding insert in playground
let cleanedText = ASRService.applyCustomDictionary(ASRService.removeFillerWords(result.text))
self.recordWordBoostHitIfAny(transcribedText: cleanedText)
DebugLogger.shared.debug("After post-processing: '\(cleanedText)'", source: "ASRService")
// Privacy: cleanedText is the post-processed dictated transcript; log length only.
DebugLogger.shared.debug("After post-processing: \(cleanedText.count) chars", source: "ASRService")
self.benchmarkLog("stop_end result=success totalMs=\(self.elapsedMilliseconds(since: stopStartedAt)) recordingAgeMs=\(self.elapsedMilliseconds(since: self.benchmarkRecordingStartedAt)) cleanedChars=\(cleanedText.count)")
if SettingsStore.shared.saveTranscriptionHistory,
SettingsStore.shared.saveAudioWithTranscriptionHistory,
Expand Down Expand Up @@ -2728,7 +2733,8 @@ final class ASRService: ObservableObject {
self.partialTranscription = updatedText
self.previousFullTranscription = newText

DebugLogger.shared.debug("✅ Streaming: '\(updatedText)' (\(String(format: "%.2f", duration))s)", source: "ASRService")
// Privacy: updatedText is the live partial transcript; log length only.
DebugLogger.shared.debug("✅ Streaming: \(updatedText.count) chars (\(String(format: "%.2f", duration))s)", source: "ASRService")
}
let rtf = chunk.isEmpty ? 0 : duration / (Double(chunk.count) / 16_000.0)
let chunkDoneAgeMs = self.elapsedMilliseconds(since: self.benchmarkRecordingStartedAt)
Expand Down
8 changes: 5 additions & 3 deletions Sources/Fluid/Services/AppleSpeechAnalyzerProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,9 @@ final class AppleSpeechAnalyzerProvider: TranscriptionProvider {
DebugLogger.shared.debug("AppleSpeechAnalyzer: Results task started, waiting for results...", source: "AppleSpeechAnalyzerProvider")
for try await case let result in freshTranscriber.results {
let text = String(result.text.characters)
DebugLogger.shared.debug("AppleSpeechAnalyzer: Got result - isFinal: \(result.isFinal), text: '\(text)'", source: "AppleSpeechAnalyzerProvider")
// Privacy: text is recognized speech; DebugLogger persists to a plaintext disk
// log, so log only its length, never the recognized content.
DebugLogger.shared.debug("AppleSpeechAnalyzer: Got result - isFinal: \(result.isFinal), text: \(text.count) chars", source: "AppleSpeechAnalyzerProvider")
if result.isFinal {
// ACCUMULATE results (per Apple's pattern) - don't break!
if !finalText.isEmpty && !text.isEmpty {
Expand All @@ -206,7 +208,7 @@ final class AppleSpeechAnalyzerProvider: TranscriptionProvider {
}
// Continue iterating until stream ends (after finalizeAndFinish)
}
DebugLogger.shared.debug("AppleSpeechAnalyzer: Results iteration complete, accumulated: '\(finalText)'", source: "AppleSpeechAnalyzerProvider")
DebugLogger.shared.debug("AppleSpeechAnalyzer: Results iteration complete, accumulated: \(finalText.count) chars", source: "AppleSpeechAnalyzerProvider")
}

// 7. Start the analyzer (this kicks off processing)
Expand Down Expand Up @@ -235,7 +237,7 @@ final class AppleSpeechAnalyzerProvider: TranscriptionProvider {
DebugLogger.shared.warning("Speech recognition error: \(error.localizedDescription)", source: "AppleSpeechAnalyzerProvider")
}

DebugLogger.shared.debug("AppleSpeechAnalyzer: Transcription complete - result: '\(finalText)'", source: "AppleSpeechAnalyzerProvider")
DebugLogger.shared.debug("AppleSpeechAnalyzer: Transcription complete - result: \(finalText.count) chars", source: "AppleSpeechAnalyzerProvider")
return ASRTranscriptionResult(text: finalText, confidence: 1.0)
}

Expand Down
3 changes: 2 additions & 1 deletion Sources/Fluid/Services/AppleSpeechProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ final class AppleSpeechProvider: TranscriptionProvider {
if let result = result, result.isFinal {
hasResumed = true
let transcription = result.bestTranscription.formattedString
DebugLogger.shared.debug("AppleSpeechProvider: Got final result: '\(transcription)'", source: "AppleSpeechProvider")
// Privacy: transcription is recognized speech; log length only.
DebugLogger.shared.debug("AppleSpeechProvider: Got final result: \(transcription.count) chars", source: "AppleSpeechProvider")
continuation.resume(returning: ASRTranscriptionResult(text: transcription, confidence: 1.0))
}
// Partial results ignored as we requested final only
Expand Down
Loading
Loading