Fix dictation prompt role separation#392
Open
sdhilip200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes dictation post-processing prompt composition so cleanup instructions are sent as the system message and the transcript is sent separately as tagged user content. Legacy custom prompts that still use
${transcript}continue to render with replacement behavior.Type of Change
Related Issues
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat Sourcessh build_incremental.shAdditional validation run locally:
xcodebuild clean build -project Fluid.xcodeproj -scheme Fluid -destination platform=macOS,arch=arm64 -derivedDataPath /private/tmp/FluidVoiceDerivedData CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO -quietxcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination platform=macOS,arch=arm64 -derivedDataPath /private/tmp/FluidVoiceDerivedData CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO -quietgit diff --checkNotes
modelcontextprotocol/swift-sdkto 0.12.1 because the previously pinned 0.10.2 fails to compile under Xcode 26.5 / Swift 6 strict-concurrency checking.sh build_incremental.shcurrently fails in this checkout because it referencesbuild_dev.sh, which is not present in the repository. Directxcodebuildbuild and test commands passed instead.swiftformat --config .swiftformat Sourceswas not committed because it rewrites broad pre-existing formatting drift outside this focused bugfix.Screenshots / Video
N/A - no UI changes.