Remove empty notebook attachments during standardization - #4470
Open
kiwoongyoon wants to merge 1 commit into
Open
kiwoongyoon wants to merge 1 commit into
kiwoongyoon wants to merge 1 commit into
Conversation
|
|
kiwoongyoon
marked this pull request as ready for review
August 31, 2026 05:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Remove empty notebook attachments during standardization
Summary
attachmentsmappings when the notebookstandardizecommand runs.Fixes #4222
Test evidence
python3 -c "import runpy; test = runpy.run_path('evalml/tests/test_notebook_version_standardizer.py')['test_standardize_removes_only_empty_attachments']; test()"python3 docs/notebook_version_standardizer.py check-versionspython3 docs/notebook_version_standardizer.py check-executiongit diff --checkAll commands exited successfully.
Risks or notes for maintainers
The supplied related-PR search was unavailable, so duplicate work should be checked before merge. The change only removes mappings exactly equal to
{}and leaves populated attachment data untouched. Pytest, Black, and Ruff were unavailable in the Builder environment.