Skip to content

ci: use shared Node version#139

Merged
francoischalifour merged 2 commits into
altertable-ai:mainfrom
albert20260301:ci/shared-node-version
Jun 30, 2026
Merged

ci: use shared Node version#139
francoischalifour merged 2 commits into
altertable-ai:mainfrom
albert20260301:ci/shared-node-version

Conversation

@albert20260301

@albert20260301 albert20260301 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add .node-version as the shared Node version source for local development and CI
  • pin the repo to Node 24.17.0 in the root package.json engines field
  • make both test workflow jobs and the release workflow read Node from .node-version
  • include .node-version in the CI dependency cache key so cached native modules cannot cross Node ABIs
  • document the Node prerequisite in the root README

Impact

This keeps dev machines and GitHub Actions on one exact Node version. Bun remains the package manager/runtime for install, build, lint, and tests; Node is pinned for tooling that runs through Node directly, including npm publish.

Validation

  • git diff --check
  • bun run typecheck
  • bun run build
  • bun run lint
  • bun run test
  • GitHub Actions: title validation, test, and integration passed

@albert20260301

Copy link
Copy Markdown
Contributor Author

@francoischalifour could you review this when you have a slot? This pins the repo to one Node line via .node-version and makes CI read from it.

@francoischalifour francoischalifour merged commit 667c224 into altertable-ai:main Jun 30, 2026
4 checks passed
@albert20260301 albert20260301 deleted the ci/shared-node-version branch June 30, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants