Skip to content

Upgrade gen_fsm to gen_statem #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuel-rubio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade gen_fsm to gen_statem #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeaeea6
#11 - use gen_fsm or gen_statem and removes neotoma because it's incl…
Feb 9, 2018
4933ea8
remove neotoma as direct dependency for myproto
Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{erl_opts, [
debug_info,
warnings_as_errors
warnings_as_errors,
{platform_define, "17|18", 'OLD_GEN_FSM'}
]}.

{deps, [
neotoma,
{sqlparser, "0.2.0"}
]}.

Expand All @@ -14,12 +14,7 @@
{plugins, [
{rebar_edown_plugin,
{git, "git://github.com/altenwald/rebar_edown_plugin.git", {branch, "master"}}
},
rebar3_neotoma_plugin
]}.

{provider_hooks, [
{pre, [{compile, {neotoma, compile}}]}
}
]}.

{edoc_opts,[
Expand Down
2 changes: 1 addition & 1 deletion rebar.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{"1.1.0",
[{<<"neotoma">>,{pkg,<<"neotoma">>,<<"1.7.3">>},0},
[{<<"neotoma">>,{pkg,<<"neotoma">>,<<"1.7.3">>},1},
{<<"sqlparser">>,{pkg,<<"sqlparser">>,<<"0.2.0">>},0}]}.
[
{pkg_hash,[
Expand Down
10 changes: 8 additions & 2 deletions src/my_request.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
-module(my_request).
-author('Manuel Rubio <manuel@altenwald.com>').

-behaviour(gen_fsm).
-ifdef(OLD_GEN_FSM).
-define(GEN_FSM, gen_fsm).
-else.
-define(GEN_FSM, gen_statem).
-endif.

-behaviour(?GEN_FSM).

-define(SERVER, ?MODULE).

Expand Down Expand Up @@ -46,7 +52,7 @@
ParseQuery :: boolean()) -> {ok, pid()}.

start(Socket, Id, Handler, ParseQuery) ->
{ok, Pid} = gen_fsm:start(?MODULE, [Socket, Id, Handler, ParseQuery], []),
{ok, Pid} = ?GEN_FSM:start(?MODULE, [Socket, Id, Handler, ParseQuery], []),
gen_tcp:controlling_process(Socket, Pid),
inet:setopts(Socket, [{active, true}]),
{ok, Pid}.
Expand Down