Repository navigation
Update demo video with bayonet selections and model picks - #187
Merged
Merged
Conversation
Focus narration on aligned geometry, shorten idle capture time, and preserve filmed inputs in completed recipes. Increase the default solver budget to 300 with a nozzle convergence regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README links to the older demonstration. Update it to the new 3:48 video, with narration focused on modeling the nozzle's bayonet mount and using relationships to avoid offset faces, off-center bores, and end faces that are not square to their cylinder axes.
The capture now starts from the bare nozzle scan, paints representative wall, rim, and slope selections, and creates fits and a parallel-plane relationship through actual Model picks. Prepared remaining features retain the exact filmed selections and fits. Shorten setup and evaluation waits, preserve completed interactions, and record playback rates, edits, and checkpoints in the manifest. Rendered media stays outside the repository.
Increase the default least-squares iteration budget from 100 to 300 so the nozzle recipe's offset cylinder converges, with a regression covering its convergence and the completed recipe.
Validation:
Known limitation: the residual scene uses the existing all-fit scale and individual fit results. It does not show full-scan or legacy joint-fit residuals, and the shared scale can make the colors look pale.