ci: cover staging, make CI safe for fork PRs, pin foundry-toolchain - #44
Merged
Conversation
- Trigger CI on pushes/PRs to staging (contributor PRs target staging; the pull_request branches filter matches the PR base, so without this a staging-based PR gets no CI at all). - Skip fork-tests on PRs from forks: secrets are never exposed there, so the job would flake on public RPC fallbacks. build-and-check remains the secret-free gate for fork PRs. - Pin foundry-rs/foundry-toolchain to the v1.9.1 SHA (closes the TODO). - Add dependabot config (github-actions + npm, weekly, targeting staging).
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of setting up the contributor workflow (feat -> staging -> main).
What
staging(contributor PRs will target staging; thepull_requestbranch filter matches the PR base, so without this a staging-based PR would get no CI).fork-testsis skipped on PRs from forks: GitHub never exposes secrets to fork PRs, so the job would flake on public-RPC fallback for every external contribution. The secret-freebuild-and-checkjob is the gate for fork PRs; fork-tests still run on internal PRs and every push to main/staging.foundry-rs/foundry-toolchainpinned to the v1.9.1 SHA (closes the in-file TODO).staging.Testing
CI on this PR runs with the updated workflow (pull_request uses the PR's merge ref).