Repository navigation
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the storage layout of the MachServiceManager contract and updates AVS configuration documentation across multiple files. The key changes include:
- Replacing the __GAP[50] with a new __DEPRECATED_SLOT204 and a reduced __GAP[49] in the storage layout.
- Updating generation block numbers and timestamps in AVS configuration details for multiple networks.
- Refreshing contract addresses in the altlayer documentation to reflect the latest deployment.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/avs-details/mainnet/xterio.md | Updated block number and timestamp |
| docs/avs-details/mainnet/soneium.md | Updated block number and timestamp |
| docs/avs-details/mainnet/gm-network.md | Updated block number and timestamp |
| docs/avs-details/mainnet/dodochain.md | Updated block number and timestamp |
| docs/avs-details/mainnet/cyber.md | Updated block number and timestamp |
| docs/avs-details/mainnet/altlayer.md | Updated block number, timestamp, and contract addresses |
| contracts/docs/storage/MachServiceManager.txt | Updated storage layout: introduced __DEPRECATED_SLOT204 and reduced __GAP array size |
Files not reviewed (1)
- contracts/src/core/MachServiceManager.sol: Language not supported
| |---------------------------+-----------------------------------------------------+------+--------+-------+----------------------------------------------------| | ||
| | __GAP | uint256[50] | 204 | 0 | 1600 | src/core/MachServiceManager.sol:MachServiceManager | | ||
| | __DEPRECATED_SLOT204 | uint256 | 204 | 0 | 32 | src/core/MachServiceManager.sol:MachServiceManager | | ||
| |---------------------------+-----------------------------------------------------+------+--------+-------+----------------------------------------------------| |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining the introduction of __DEPRECATED_SLOT204 and the rationale behind reducing the __GAP array size. This additional context will help maintainers understand the storage layout changes.
renlulu
left a comment
renlulu
left a comment
There was a problem hiding this comment.
No high-confidence PR-introduced issues found.
I reviewed the storage layout refactor with forge build, forge inspect ... storage-layout, targeted forge test --match-contract MachServiceManagerTest (38 tests), and EIP-1967 proxy implementation slot checks for the documented AltLayer addresses at block 22395872. The storage layout matches the checked-in report, with pauserRegistry still at slot 254. I did not run the full test suite beyond the targeted MachServiceManager tests.
This pull request includes updates to the storage layout of the
MachServiceManagercontract and documentation changes for AVS configuration details across multiple files. The most significant changes involve introducing a new deprecated storage slot in the contract and updating documentation to reflect new block generation details and contract addresses.Contract Changes:
MachServiceManagerby replacing the__GAParray of size 50 with a new__DEPRECATED_SLOT204and a reduced__GAParray of size 49 to maintain compatibility while marking a specific storage slot as deprecated. (contracts/docs/storage/MachServiceManager.txt,contracts/src/core/MachServiceManager.sol) [1] [2]Documentation Updates:
22244692to22395872and corresponding timestamps in AVS configuration files. (docs/avs-details/mainnet/altlayer.md,docs/avs-details/mainnet/cyber.md,docs/avs-details/mainnet/dodochain.md,docs/avs-details/mainnet/gm-network.md,docs/avs-details/mainnet/soneium.md,docs/avs-details/mainnet/xterio.md) [1] [2] [3] [4] [5] [6]altlayer.mdfile to reflect the latest deployed versions. (docs/avs-details/mainnet/altlayer.md)