add parse batch size to UI - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gabe and Johannes had a lot of fun learning about git and why squash merges create trouble when you don't delete or update the dev branch from the new main...
We wired that one batch size into the UI that makes sure the ZMQ pub happens frequently enough
Also the queues are now displayed in the main DAQ window, so the user would see if the batch size is too small for the current count rate.
Everything is tested on the BL machine with the LED creating real counts on the TimePix3.
This should remain main for this beamtime at least.
Gabe will work on EPICS stuff in a separate branch.
Johannes will work on UI stuff in a separate branch.