Skip to content

Added a feature to save frame data#27

Closed
haji-ali wants to merge 1 commit into
alphapapa:masterfrom
haji-ali:save-frame-data
Closed

Added a feature to save frame data#27
haji-ali wants to merge 1 commit into
alphapapa:masterfrom
haji-ali:save-frame-data

Conversation

@haji-ali

@haji-ali haji-ali commented Jun 2, 2024

Copy link
Copy Markdown

For your consideration, I implemented a feature to save the frame data for any frame type, such that the frame becomes persistent (saving tabs and windows across invocations).

@alphapapa

Copy link
Copy Markdown
Owner

Hi,

This is an interesting idea, but given that I've already written https://github.com/alphapapa/burly.el and https://github.com/alphapapa/activities.el, which do this outside of Yequake, I'd be reluctant to add a third implementation of essentially the same functionality to another library of mine, especially considering the complexities involved (e.g. I'd rather have to fix issues in as few implementations as possible).

I think it would probably be better to either add some kind of integration with Burly and/or Activities, or document how the user can call Burly/Activities functions in a Yequake frame configuration to do the same thing.

What do you think?

Thanks.

@haji-ali

haji-ali commented Jun 3, 2024

Copy link
Copy Markdown
Author

Definitely better to integrate/use existing libraries (I didn't know of your burly and activities). I will need some time to figure out how to do what I want in activities for example.

Yequake might also need to add a few hooks to call activities-define, activities-suspend and activities-resume (I guess). One thing I was also unsure about (design-wise) is if buffer-fns should be called again when the frame is restored.

Edit: Just realized that this PR might also be related to #17

@haji-ali haji-ali closed this Jun 3, 2024
@alphapapa

Copy link
Copy Markdown
Owner

Thanks. And, yes, #17 would probably be a good option to have as well as some kind of integration with Activities. Feel free to open issues here or on Activities' repo to discuss changes needed to integrate them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants