Make sure the function pointer of 'org-switch-to-buffer-other-window' is set.#21
Open
Alexander-Miller wants to merge 1 commit into
Open
Make sure the function pointer of 'org-switch-to-buffer-other-window' is set.#21Alexander-Miller wants to merge 1 commit into
Alexander-Miller wants to merge 1 commit into
Conversation
… is set. If org-mode has not yet been loaded when yequake-org-capture is run it will only be required as part of org-capture's autoload. That means that the function pointer of org-switch-to-buffer-other-window is nil by the time the switch happens, thus nil is also the value that will be restored by cl-letf*. By manually loading org we make sure that the function pointer is set correctly before the switch happens. Doing so has no impact on performance since the org-capture autoload would do it anyway.
Owner
|
Thanks. I'll apply this when I work on this package again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If org-mode has not yet been loaded when yequake-org-capture is run it will only
be required as part of org-capture's autoload. That means that the function
pointer of org-switch-to-buffer-other-window is nil by the time the switch
happens, thus nil is also the value that will be restored by cl-letf*.
By manually loading org we make sure that the function pointer is set correctly
before the switch happens. Doing so has no impact on performance since the
org-capture autoload would do it anyway.