Skip to content

Resolve LGTM errors#44

Open
lisaychuang wants to merge 2 commits into
alphagov:gh-pagesfrom
lisaychuang:lgtm-alerts
Open

Resolve LGTM errors#44
lisaychuang wants to merge 2 commits into
alphagov:gh-pagesfrom
lisaychuang:lgtm-alerts

Conversation

@lisaychuang

Copy link
Copy Markdown

Resolve LGTM errors (see LGTM alert snapshot here):

  • Added let variable declaration in for...in statements, line 151 & line 152
  • Update all variable declarations from var to let

@lisaychuang

Copy link
Copy Markdown
Author

Resolve LGTM errors in analysis.js file, see LGTM alert snapshot here

  • Update all variable declarations from var to let
  • Removed unused variables: test, percent in analyse() function
  • Added let variable declaration in for...in statements, line 55,56,59
  • Added let variable declaration for tr_ew (line 107), tr_ewm (line 117)

@lisaychuang

Copy link
Copy Markdown
Author

@selfthinker please review when you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant