Added timezone awareness in time variables throughout to fix time conversion issues.#142
Open
ic-gcp wants to merge 4 commits into
Open
Added timezone awareness in time variables throughout to fix time conversion issues.#142ic-gcp wants to merge 4 commits into
ic-gcp wants to merge 4 commits into
Conversation
Changed code to use timezone aware timestamps for dtbegin and dtend, so that they are converted correctly to the users passed timezone
Made changes in the function "_make_sure_dates_are_initialized_properly" so that dtend and dtbegin are localized correctly according to the timezone specified by the user.
Contributor
|
hi, this PR has conflicts with commits that are handling similar issues. |
Contributor
Author
|
The master doesn't already solve the issue. I've fixed the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dtbegin and dtend now contain timezone specified by the user in datafactory.