Auto disable - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
autoDisableparameter to the FireAndForget library, enabling automatic flag disabling on first access without requiring manualdisable()calls.Changes
Core Library Updates
FireAndForget.kt (core/src/commonMain/kotlin/com/alorma/fireandforget/FireAndForget.kt:7)
autoDisable: Boolean = falseparameter to theFireAndForgetconstructortrue, the flag automatically disables itself on first call toisEnabled()FireAndForgetRunner.kt (core/src/commonMain/kotlin/com/alorma/fireandforget/FireAndForgetRunner.kt:4)
isEnabled()from abstract to concrete method with auto-disable logiccheckEnabled()for runner implementationsisEnabled()now checks the flag state and automatically callsdisable()if:autoDisableis set totrueImplementation Updates
Updated all runner implementations to use the new
checkEnabled()method:Documentation
README.md updates include:
autoDisableparameter documentationcheckEnabled()patterncheckEnabled()instead ofisEnabled()Sample Code
autoDisablefeature in actionUse Case
Perfect for truly "fire-and-forget" scenarios where there's no natural completion callback:
Architecture Decision
The
isEnabled()method is now final inFireAndForgetRunnerto ensure the auto-disable logic cannot be bypassed by custom implementations. All runner implementations must overridecheckEnabled()instead, which is called internally byisEnabled().Testing
autoDisable = falsedefault)