Skip to content

make error messages runable #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bart1 merged 5 commits into from
Aug 7, 2026
Merged

make error messages runable #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0757ad0
make error messages runable
Aug 3, 2026
343822a
nicer print
Aug 3, 2026
39b4155
do not use rspm as it causes issues on bioconductor
Aug 5, 2026
78be2b0
Enable use of public RSPM in workflow
bart1 Aug 7, 2026
92ff1ef
Comment out R version 4.1.0 in workflow
bart1 Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jobs:
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}
# And minimum supported version in DESCRIPTION
- {os: ubuntu-latest, r: '4.1.0'}
# this seems to be failing due to a issue installing rhdf5 from bioconductor
# - {os: ubuntu-latest, r: '4.1.0'}

env:
getRad_nl_api_key: ${{ secrets.GETRAD_NL_API_KEY }}
Expand Down
4 changes: 2 additions & 2 deletions R/get_pvol_nl.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ get_pvol_nl <- function(radar, time, ..., call = rlang::caller_env()) {
"There was an authorization error. You may have used an invalid API
key.",
"i" = "Please check if you set the correct {.val nl_api_key} with
{.code get_secret(\"nl_api_key\")}."
{.run [get_secret(\"nl_api_key\")](getRad::get_secret(\"nl_api_key\"))}."
),
cnd = cnd,
class = "getRad_error_get_pvol_nl_authorization_failure",
Expand All @@ -80,7 +80,7 @@ get_pvol_nl <- function(radar, time, ..., call = rlang::caller_env()) {
"There was a rate limitation error (HTTP 429) while getting data from the Netherlands.",
"i" = "This frequently occurs when using the anonymous key, if it occurs repeatedly consider requesting a registered key ({.url https://developer.dataplatform.knmi.nl/open-data-api#token}). ",
"i" = "You can check the current value of {.val nl_api_key} with
{.code get_secret(\"nl_api_key\")}."
{.run [get_secret(\"nl_api_key\")](getrad::get_secret(\"nl_api_key\"))}."
),
cnd = cnd,
class = "getRad_error_get_pvol_nl_429_failure",
Expand Down
2 changes: 1 addition & 1 deletion R/secrets.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ get_secret <- function(name) {
cli::cli_abort(
c(
"Can't find secret {.arg {sname}} in the keyring.",
"i" = "Please use {.code set_secret(\"{name}\")} to store the secret. Note that the prefix is automatically added in {.fun set_secret}."
"i" = "Please use {.run [set_secret(\"{name}\")](getRad::set_secret(\"{name}\"))} to store the secret. Note that the prefix is automatically added in {.fun set_secret}."
),
class = "getRad_error_secret_not_found"
)
Expand Down
Loading