Return more descriptive error for german data query (data too old) - #132
Merged
bart1 merged 12 commits intoSep 30, 2025
Merged
Conversation
capitalization
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 92.66% 92.21% -0.46%
==========================================
Files 24 24
Lines 1472 1733 +261
==========================================
+ Hits 1364 1598 +234
- Misses 108 135 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
Can you keep this in draft until it's ready to review? |
Collaborator
Author
|
Sorry it was ready to review but i merged changes from main to see how the code formatter worked :) |
PietrH
approved these changes
Sep 30, 2025
PietrH
left a comment
Contributor
There was a problem hiding this comment.
Two small notes, non blocking for merging.
- I suggest renaming the error class.
- I suggest making the skip even more strict so we also skip the test if the data provider is offline. But it's worth staying consistent for all tests in the package.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bart1
deleted the
131-error-for-selecting-a-old-german-data-is-unclear
branch
September 30, 2025 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old error:
Requested data is too old, only the last 3 days are available
Created on 2025-09-29 with reprex v2.1.1
This is the new error:
Created on 2025-09-29 with reprex v2.1.1