DCC2: complete eligibility fixtures - #273
Merged
CamilleFljt merged 2 commits intoSep 2, 2026
Merged
Conversation
greg-olivier
approved these changes
Sep 1, 2026
greg-olivier
left a comment
greg-olivier
left a comment
Member
There was a problem hiding this comment.
Nothing is blocking for me, just a few suggestions/questions 🙂
| * Returns a copy of `plan` with its `transaction_country` overridden. | ||
| * The input plan is never mutated, so shared fixtures stay reusable across tests. | ||
| */ | ||
| export const withCountry = <T extends EligibilityPlan>(plan: T, countryCode: string): T => ({ |
Member
There was a problem hiding this comment.
Q: Why use generic here ? Does a (plan: EligibilityPlan, countryCode: string): EligibilityPlan is sufficient ?
Contributor
Author
There was a problem hiding this comment.
You're absolutely right it's sufficient !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eligibility API now returns a
transaction_countryon each plan. Nothing consumes it yet, this PR gets the types and the test fixtures ready so the feature work can land on top without touching every fixture again.While in there, the fixture file was missing the deferred plan shapes we need for the upcoming work, so they're added too.