Allow specifying datasets in configs, change default optimizer, improved CUDA support#1
Merged
Conversation
fizzAI
changed the title
fizzAI
marked this pull request as draft
January 23, 2026 23:00
fizzAI
force-pushed
the
fizzAI-patch-1
branch
from
January 23, 2026 23:35
5201713 to
b9038e7
Compare
fizzAI
changed the title
fizzAI
marked this pull request as ready for review
January 23, 2026 23:39
aronson
self-requested a review
January 23, 2026 23:42
aronson
requested changes
Jan 23, 2026
aronson
left a comment
aronson
left a comment
Member
There was a problem hiding this comment.
looks really good, I need to take ~30 minutes to run 2-3 tests on my mac to make sure we still have feature parity. if you could, @fizzAI can you post a screenshot of the application working on your CUDA setup? also name tersely which CUDA version and card you're using for posterity. then I can merge np
Member
|
LGTM over here Screen.Recording.2026-01-23.at.5.51.05.PM.mov |
Member
Author
Nvidia GTX 1650 Super, Cuda 12 MLX and Cuda runtime |
Signed-off-by: Heni <i@pingas.org>
aronson
force-pushed
the
fizzAI-patch-1
branch
from
January 24, 2026 00:03
868d22f to
b03c476
Compare
aronson
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdamW is one morbillion times better than Adam