fix(provider): avoid confirmation height underflow - #4143
Open
questfever wants to merge 1 commit into
Open
Conversation
questfever
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
onbjerg
as code owners
August 13, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PendingTransactionConfig::with_required_confirmationsaccepts anyu64, including0.Most heartbeat paths compute the confirmation target block with
block_height + confirmations - 1. This can underflow whenconfirmations == 0and the transaction is observed at block0, and it can also overflow for very large confirmation counts.The new-block path already treats
confirmations <= 1as immediately confirmed, so the historical/already-confirmed paths should handle0consistently instead of panicking.Solution
block_height + confirmations - 1required_confirmations = 0in already-confirmed and lookbehind pathsPR Checklist