Fix build warnings exposed by newer GCC (-Werror)#458
Merged
carlgsmith merged 1 commit intoJun 5, 2026
Conversation
These are pre-existing latent issues only flagged as errors by newer GCC (CI uses GCC 11; they surface on GCC 16). They block building the tree at all, so fix them first: - hashtree.h: header guard #define did not match the #ifndef token (_HASHTREE_H_H vs _HASHTREE_H_), tripping -Wheader-guard. - config.c, apteryx.c: strrchr/strstr on a const char* were assigned to char*, discarding const (-Wdiscarded-qualifiers). Use const pointers; the values are only read. - apteryx.c handle_index(): drop the write-only loop counter i (-Wunused-but-set-variable). No functional change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are pre-existing latent issues only flagged as errors by newer GCC (CI uses GCC 11; they surface on GCC 16). They block building the tree at all, so fix them first:
No functional change.