Skip to content

fix: close file handles in tree loader and citation eval#616

Open
Chessing234 wants to merge 1 commit into
allenai:mainfrom
Chessing234:fix/unclosed-file-handles-tree-eval
Open

fix: close file handles in tree loader and citation eval#616
Chessing234 wants to merge 1 commit into
allenai:mainfrom
Chessing234:fix/unclosed-file-handles-tree-eval

Conversation

@Chessing234

Copy link
Copy Markdown

Summary

  • Use context managers when reading the UMLS semantic type tree file in umls_semantic_type_tree.py.
  • Use a context manager when reading citation evaluation data in sentence_splitting_evaluation.py.

Test plan

  • Import build_umls_semantic_type_tree and run citation eval script without leaking file handles

Made with Cursor

Use context managers when reading UMLS semantic type tree and citation data files.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant