Fix remaining open issues: typos, resource leaks, Hearst pattern, scorer#613
Open
Chessing234 wants to merge 1 commit into
Open
Fix remaining open issues: typos, resource leaks, Hearst pattern, scorer#613Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
- Fix constructor typo in CandidateGenerator (allenai#601) - Truncate cache filename hashes for eCryptfs/encfs (allenai#590) - Rename empty TF-IDF counter variable (allenai#593) - Fix which_look_like Hearst pattern hypernym (allenai#595) - Close file handles in data_util and evaluate_ner (allenai#599, allenai#597) - Fix PerClassScorer span pairing (allenai#592) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses several small open bugs reported in issues:
CandidateGeneratordocstring (constructor)number_of_empty_tfidfsvariablewhich_look_likeHearst pattern to end withhypernymwith open()for file handles indata_util.pyandtrain_utils.pyPerClassScorerspan pairing (iterate predicted spans directly)Test plan
Made with Cursor