fix: use list instead of set for ordered span zip in PerClassScorer#611
Open
Chessing234 wants to merge 1 commit into
Open
fix: use list instead of set for ordered span zip in PerClassScorer#611Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
…ixes allenai#592) Sets do not preserve insertion order, so zipping untyped_predicted_spans with predicted_spans could pair the wrong spans when scoring NER metrics. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
untyped_predicted_spansfrom a set to a list inPerClassScorer(Fixes fix: set-list zip produces incorrect span pairings in PerClassScorer (candidate_generation.py) #592)zip(untyped_predicted_spans, predicted_spans)pairs the correct spans for untyped precision/recall metricsTest plan
Made with Cursor