Truncate cache filenames and rename empty TF-IDF counter#609
Open
Chessing234 wants to merge 1 commit into
Open
Truncate cache filenames and rename empty TF-IDF counter#609Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Shorten URL/ETag hashes in cached filenames to avoid OSError on eCryptfs/encfs filesystems, and rename number_of_non_empty_tfidfs to number_of_empty_tfidfs to match what it counts. Fixes allenai#590 and allenai#593. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
url_to_filename()to avoidOSError: File name too longon eCryptfs/encfs filesystemsnumber_of_non_empty_tfidfstonumber_of_empty_tfidfsto match what the variable countsIssues addressed
Fixes #590, #593
Test plan
Made with Cursor