fix: close metrics file and use write mode in evaluate_ner#603
Open
Chessing234 wants to merge 1 commit into
Open
fix: close metrics file and use write mode in evaluate_ner#603Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Use a context manager and "w" mode so metrics are flushed/closed and re-runs overwrite instead of appending invalid concatenated JSON. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597
evaluate_nerdumped metrics withjson.dump(metrics, open(dump_path, "a+")), leaving the handle unclosed and using append mode. Each re-run to the same--outputpath concatenated JSON objects into an invalid file.Use
with open(dump_path, "w")so the file is closed/flushed and each evaluation overwrites with a single valid JSON object.Made with Cursor