Review kind filter + polish; audit LOW items (goals 0002 + 0025 close) - #9
Merged
Conversation
…025 close Review queue (goal 0002 item 4, its last): a kind Select over the four pending kinds (policy ask / human review / breakpoint / MCP write — discriminated off the same fields each row's own icon and badge already key on, wording reused verbatim from row prose, fixed option order), shown only at 2+ kinds present (the single-option-select-is-noise rule); Blankslate empty state + Spinner loading replace the bare div/ nothing. E2e: kind-filter narrowing + emptied-queue Blankslate (mcpTestClient.ts now the shared real-MCP-client helper across three specs). Audit LOW items (goal 0025 item 9, its last): WorkflowHoverPreview clears its hover timer on unmount; unused PageContainerVariant export removed; authoring-validation's single-node canvas click hardened with the sibling specs' candidate-point pattern. Both goals archived (0002's badge item was 0005's build; every other box checked). Rides along per the intake rule: SPEC §4 gains the owner-named communication-preset design input (Discord/Telegram/ Twilio/ntfy — goal 0023's generic forward already reaches them all; a preset earns a build on real friction). Gates: tsc/eslint/loc clean, 178 vitest, suite 153 passed (the new kind-filter test was flaky-then-passed once — first observation, logged against ADR-0034's quarantine threshold, watched). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft
alicoding
enabled auto-merge
August 12, 2026 01:44
alicoding
added a commit
that referenced
this pull request
Aug 13, 2026
…anding #9) NotifyPendingApproval's away branch now requests a single informational dock bounce (window.Flash, wails beta.6's macOS support) alongside the OS notification and floating prompt -- same kernel attention-layer class as the dock badge (ADR-0035). The notify adapter's cgo send aborts headless, so only the nil-window guard is unit-testable; the real bounce is a manual-only desktop check (testing.md). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJ8wStsHyu7XPLTspNjMnQ
alicoding
added a commit
that referenced
this pull request
Aug 13, 2026
…anding #9) (#57) NotifyPendingApproval's away branch now requests a single informational dock bounce (window.Flash, wails beta.6's macOS support) alongside the OS notification and floating prompt -- same kernel attention-layer class as the dock badge (ADR-0035). The notify adapter's cgo send aborts headless, so only the nil-window guard is unit-testable; the real bounce is a manual-only desktop check (testing.md). Claude-Session: https://claude.ai/code/session_01FJ8wStsHyu7XPLTspNjMnQ Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
New capability, not previously named anywhere in SPEC.md. Cmd+1 through Cmd+5 jump straight to a top-level view (Composition/Configure/ Activity/Runs/Spec, matching the sidebar's own order) via a plain keydown listener in App.tsx calling the existing useAppStore setView -- no new navigation mechanism, reuses exactly what the sidebar's own nav links already call. Deliberately in-window-only, not a real OS-level golang.design/x/hotkey registration the way per-workflow and summon hotkeys use (§3.4/§3.7): registering these globally would mean checking each combo against TriggerService's own claimed-combo conflict space, the same bidirectional check the summon hotkey already goes through -- a bigger design surface this pass intentionally didn't take on. The safer, reversible default named directly in the session goal that built this. Active regardless of which element has focus -- matches browsers'/ Slack's own Cmd+1-9 tab-switching precedent (Cmd+digit isn't a combo real typing produces, so there's no need to scope it away from text inputs). Verified directly, not assumed: a real e2e test confirms a hotkey fires correctly even while a text field has focus. Verified end-to-end via Playwright against the real server-mode backend (view-hotkeys.spec.ts, run twice): all five hotkeys navigate correctly from a cold start, checked against real existing markers per view (Composition/Configure's own tablist aria-labels, Activity/ Runs' own h1 headings, Spec's own capability-index testid) rather than new testids added just for this; a bare digit key without Cmd does nothing. Full frontend check suite (tsc, eslint, boundaries, vitest) clean. Documented in docs/SPEC.md §3.7. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
Review kind filter + polish; audit LOW items (goals 0002 + 0025 close)
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
…anding #9) (#57) NotifyPendingApproval's away branch now requests a single informational dock bounce (window.Flash, wails beta.6's macOS support) alongside the OS notification and floating prompt -- same kernel attention-layer class as the dock badge (ADR-0035). The notify adapter's cgo send aborts headless, so only the nil-window guard is unit-testable; the real bounce is a manual-only desktop check (testing.md). Claude-Session: https://claude.ai/code/session_01FJ8wStsHyu7XPLTspNjMnQ Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last open boxes of two goals:
Both goal files archived. Gates green: 178 vitest, 153 e2e (one first-observation flaky-then-pass on the new test, logged against ADR-0034's quarantine threshold).
🤖 Generated with Claude Code
https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft