feat: real-engine drawio editor-layout smoke check (goal 0259) + smoke-harness riders - #536
Merged
Merged
Conversation
…anel in the window model, overridable bridge port drawio-editor-layout drives the REAL WKWebView: lands a two-page fixture via the drop RPC, asserts band-click selection produces the full resize-handle set, opens the embedded editor, and measures that the dialog, its iframe, and drawio's own page-tab bar all sit inside the real window (goal 0259 -- both engines now measure correct at harness sizes; the check is the permanent regression net). PASSED against a 618px-tall real window. Riders the run itself surfaced: the app-info window model learns the traypanel window (stale since the menu-bar surface landed -- it failed every smoke run); the harness port yields to MILL_SMOKE_MCP_PORT so the smoke can run beside a live installed Mill -- which itself holds 9099 because the production build ships the bridge, recorded separately as a P1 (BACKLOG 0P0-BRIDGE), as is the real-engine sticky shift-click failure the same run caught (0P0-STICKY). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check the owner asked for, made permanent:
drawio-editor-layoutdrives the REAL WKWebView window — lands a two-page .drawio fixture through the drop RPC, asserts band-click selection produces the full resize-handle set, opens the embedded editor, and measures that the dialog, its iframe, and drawio's own page-tab bar all sit inside the real window. Passed repeatedly, even against a 618px-tall window. Combined with the Chromium repro, both engines now measure correct at harness sizes — the check stays as goal 0259's regression net while the owner's exact live state is pinned.Riders the run itself surfaced:
app-infowindow model learns the traypanel window (stale since the menu-bar surface — it failed every smoke run since goal 0189);MILL_SMOKE_MCP_PORTso the smoke can run beside a live installed Mill;🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq