fix: the app launches again — promise-view attach deferred to runtime-ready (goal 0256 P0) - #535
Merged
Merged
Conversation
…-ready (goal 0256 P0) The beta carrying #534 crashed at launch: AttachFilePromiseReceiver ran InvokeSync from main.go's wiring, BEFORE app.Run() -- and the toolkit's main-thread dispatcher doesn't exist yet, so the dispatch dereferenced nil (SIGSEGV, reproduced on a local desktop launch and pinned to the exact frame). The native attach now waits for the window's first RuntimeReady event, which by construction fires only once the run loop is live; the callback registration itself stays immediate. Verified: the rebuilt desktop binary launches and survives where the previous one died in under a second. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0: the beta carrying #534 crashed at launch, reproduced locally and pinned —
AttachFilePromiseReceiverranInvokeSyncfrom main.go's wiring beforeapp.Run(), and the toolkit's main-thread dispatcher doesn't exist yet (nil deref indispatchOnMainThread, SIGSEGV in under a second).The native attach now waits for the window's first
RuntimeReadyevent, which by construction fires only once the run loop is live. Verified: the rebuilt desktop binary launches and survives where the previous one died instantly.🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq