fix: note toolbar floats above the full-size overlay, and pressing it keeps the edit alive - #532
Merged
Merged
Conversation
…g it keeps the edit alive The selection toolbar's body-level element sat at z-index 100 while Primer's portal root (every Dialog) sits at 1200 -- in the full-size note overlay the toolbar existed with data-show=true yet the dialog painted over it and swallowed its clicks. Raised above the portal root; topmost is safe since the toolbar only exists while its editor has focus. Second latent defect behind it: MarkdownNoteField's outside-press commit lacked the [data-milkdown-selection-toolbar] exclusion AtlasStickyNode already carries, so once visible, a toolbar press would have committed the overlay edit closed before the format applied. Same exclusion added. Regression e2e hit-tests the toolbar's center (Playwright visibility was true throughout the bug) and asserts Bold applies with the editor still mounted. Follow-up to goal 0253. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to goal 0253 (owner-reported on the installed build): the floating selection toolbar never appeared in the full-size note overlay.
Two defects, both fixed:
z-index: 100; Primer's portal root (#__primerPortalRoot__, every Dialog) sits at 1200. The toolbar existed withdata-show=trueyet the dialog surface painted over it and swallowed its clicks. Raised to 1300 — topmost is safe since it only exists while its editor has focus.MarkdownNoteField's outside-press commit lacked the[data-milkdown-selection-toolbar]exclusionAtlasStickyNodealready carries, so once visible, a toolbar press would have committed the overlay edit closed before the format applied.Regression e2e (
atlas-note-formatting.spec.ts) hit-tests the toolbar's own center viaelementFromPoint— Playwright visibility wastruethroughout the bug, so visibility alone can't pin it — and asserts Bold applies with the editor still mounted, surviving into both the overlay and the committed sticky.Verified live via server-mode probe: toolbar on top of the dialog, Bold round-trips.
🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq