feat: typing [x] at a note line start creates a to-do, and Enter continues the list unchecked (goal 0254) - #531
Merged
Merged
Conversation
…inues the list unchecked (goal 0254) The engine's own task rule only fires inside an existing list item, so the converged line-start syntax ([] / [ ] / [x] ) did nothing in a plain paragraph. Mill adds one input rule through the engine's own extension seam: at a paragraph start it wraps the line into a task item with the matching state; inside a list item it re-marks (the stock rule can't touch [] or an item that is already a to-do). Enter at the end of a checked to-do now splits with the NEW item born unchecked -- intercepted at the view level so the state never changes after the item mounts (a post-split attr flip was measured to remount the checkbox widget under the caret and drop in-flight keystrokes). The formatting-affordance e2e cases split into their own spec along the 500-line seam. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-raised: "which one lets you do
[x] todo— because none of it does right now." They were right: the engine's own task rule only fires INSIDE an existing list item, so the converged line-start syntax did nothing, and the only working path was the undiscoverable, flaky two-step (-then[ ]).Two pieces, both through the engine's own extension surface:
[],[ ], or[x]at the start of a plain paragraph wraps the line into a task item with the matching state (the Notion-family convention this WYSIWYG adopted into). Inside a list item it re-marks — covering[]and already-task items, which the stock rule structurally can't touch.Proof: new e2e in atlas-note-formatting.spec.ts (conversion, continuation, commit round-trip as real checkboxes — with the file's established settle/recovery guards for the engine's documented remount trait); the formatting-affordance cases split into their own spec along the 500-line seam; note suites + 985 unit tests green; screenshots reviewed. Userdocs names the shortcut.
🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq