fix: a plugin's objects survive its removal visibly, and its tool joins the palette (0249/0251 audit riders) - #521
Merged
Conversation
…ns the palette (0249/0251 audit riders) Fresh gap audit of the plugin platform found two real holes. (1) An unregistered Kind rendered null — a disabled/uninstalled plugin's already-placed objects became invisible, unselectable and undeletable, silently breaking the 'objects stay untouched' promise; same for an ingestion-claimed kind whose plugin never registered. They now render a neutral fallback face (dashed, muted, names why it isn't live) and stay deletable through the standard context menu — proven by a two-server restart e2e. (2) Built-in tools each have an atlas.create.<id> palette command; plugin tools had none — the host now collects one per registered object through the same channel plugin commands ride (surface-scoped to atlas, arming the identical placement mechanism), proven by a palette e2e. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh do-not-trust-the-pattern audit of the plugin platform (owner's standing directive) found two real gaps on main:
AtlasBoardObjectNodereturnednullfor an unregistered Kind — so a disabled/uninstalled plugin's already-placed objects vanished (invisible, unselectable, undeletable), silently breaking 0249's own "objects it already placed stay on your boards untouched" promise. Same hole for an ingestion-claimed kind whose plugin never registered. They now render a neutral fallback face (dashed, muted, "Its extension isn't running…") and stay fully manageable — proven by a two-server e2e that places a bookmark, restarts WITHOUT the plugin, and deletes the orphan through the standard context menu.atlas.create.<id>palette command; plugin tools had none. The host now collects one per registered canvas object through the same collector plugin commands already ride (surface-scoped to atlas via a newRuntimeCommandDecl.surface, arming the identical placement mechanism with the established one-documented-cast) — proven by a palette e2e (⌘/ on atlas → "Bookmark" option).Full runtime-plugins suite 6/6, vitest 970/970.
🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq