feat: minMillVersion is enforced — a plugin needing a newer Mill is refused, visibly (goal 0245) - #518
Merged
Merged
Conversation
…efused, visibly (goal 0245) The stability contract's teeth: the plugin surface versions against Mill's own version (the converged app-plugin model), and the manifest's minMillVersion — parsed but never checked until now — is enforced at scan, so every valid-manifest-only consumer (loader, assets, ingestion claims, guarded actions) inherits the refusal. The Extensions row names both versions; a beta satisfies the release it is stamped against (prerelease stripped before compare); a malformed minimum fails closed; an unstamped source build skips enforcement. Stability promise recorded in the Extending-the-canvas docs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
alicoding
enabled auto-merge (squash)
August 29, 2026 15:46
…urce build's version const is the last release, not this build's lineage Caught by CI: the e2e/dev server builds unstamped (version const 0.5.0) and refused mill-bookmark's 0.9.0 pin -- the freshest possible code failing a minimum it satisfies. Channel-aware now: source skips, beta/ stable enforce; pinned-plugin behavior proven per channel in wiring. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin stability contract's teeth (goal 0245's boundary slice).
minMillVersionwas parsed since 0249 but never checked — a plugin demanding a newer Mill loaded silently against a surface it postdates.checkMinMillVersion), so every valid-manifest-only consumer — loader, asset route, ingestion claims, guarded actions — inherits the refusal through the existing fail-closed paths.Proof: 8-row table test on the comparator + a scan-level test pinning that the refusal reaches
ListPlugins.🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq