fix: every registered extension appears -- the list derives from nouns, not tray tools (goal 0237) - #509
Merged
Merged
Conversation
…s, not tray tools (goal 0237) Settings > Extensions was built off ATLAS_TOOLS (tray tools only), so diagram and sheet -- both file-drop-only nouns with no tray identity -- were invisible even though they're fully registered canvas nouns. The list now derives from every registered noun: tray tools plus tool-less nouns (diagram, sheet), normalized into one ExtensionRowSource shape (extensionMeta.ts) so ExtensionRow.tsx never branches on which kind of noun it's rendering. Diagram and sheet declare their own icon/label/description/disableScopeNote via a new optional `extension` field on AtlasNounContent, read back by atlasNounRegistry.ts's toolLessNounExtensions(). Disabling a tool-less noun has no tray button to remove, so its row states the honest, narrower scope: it gates useAtlasNativeFileDrop.ts's own drop routing (extracted into the pure, testable resolveFileDropKind) and, for diagram, dispatchObjectEdit's embedded-engine door (already keyed off object.Kind since goal 0244). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ATLAS_TOOLS(tray tools only), so diagram and sheet -- both file-drop-only nouns with no tray identity -- never appeared even though both are fully registered canvas nouns.toolLessNounExtensions()), normalized into oneExtensionRowSourceshape (extensionMeta.ts) soExtensionRow.tsxnever branches on which kind of noun it's rendering. Diagram and sheet declare their own icon/label/description/disableScopeNote via a new optionalextensionfield onAtlasNounContent.useAtlasNativeFileDrop.ts's own drop routing (extracted into the pure, testableresolveFileDropKind) and, for diagram,dispatchObjectEdit's embedded-engine door (already keyed offobject.Kindsince goal 0244).userdocs/reference/extending-the-canvas.md's generated field table regenerated (go generate ./internal/docsgen) to describe the newextensionmember.Test plan
npx tsc --noEmitcleannpx eslintclean on every changed filenpx vitest run-- 121 files / 960 tests passing (includes newresolveFileDropKindandtoolRowSource/toolLessRowSourceunit tests)npx playwright test e2e/settings-extensions.spec.ts-- 6/6 passing, including a new test asserting diagram/sheet rows and their disable-scope copygo build ./...,go vet ./...,go test ./internal/docsgen/...all greenscripts/check-comment-hygiene.sh,scripts/check-loc.sh,scripts/check-ui-copy.shall green🤖 Generated with Claude Code
https://claude.ai/code/session_012im1JxQQV2ahnXzZDdVmZq