feat: workflow pins/favorites (BACKLOG Standing #5) - #50
Merged
Conversation
A plain ordered workflow-ID list (shared/store.ts's pinnedWorkflowIds, persisted via the existing zustand `persist` localStorage tier, same pattern as goal 0033's activeWorkTabKey) with a togglePinnedWorkflow action. app/workflowFrecency.ts gains sortWorkflowsByPinnedAndFrecency, partitioning pinned rows (in pin order) above the existing frecency-sorted unpinned tail rather than a second ranking algorithm. A subtle Primer PinIcon toggle lands on both the Quick Panel's and the ⌘K palette's workflow rows -- muted outline unpinned, accent-colored once pinned. Along the way, found and fixed a real Primer interaction bug: ActionList.Item's TrailingVisual wraps children in a VisualWrap span with pointer-events: none (trailing visuals are decorative-only by the library's own convention), which silently ate every click on the toggle until pointer-events: auto was added back on the button itself. Vitest covers the pinned-above-frecency/pin-order/dropped-stale-id/ no-mutation cases; quick-panel.spec.ts gained a full pin-sorts-above-frecency -> unpin-reverts -> persists-across-reload e2e case. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018pkViCNAuZp2vBv2K9AbUh
alicoding
enabled auto-merge (squash)
August 13, 2026 05:36
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
A plain ordered workflow-ID list (shared/store.ts's pinnedWorkflowIds, persisted via the existing zustand `persist` localStorage tier, same pattern as goal 0033's activeWorkTabKey) with a togglePinnedWorkflow action. app/workflowFrecency.ts gains sortWorkflowsByPinnedAndFrecency, partitioning pinned rows (in pin order) above the existing frecency-sorted unpinned tail rather than a second ranking algorithm. A subtle Primer PinIcon toggle lands on both the Quick Panel's and the ⌘K palette's workflow rows -- muted outline unpinned, accent-colored once pinned. Along the way, found and fixed a real Primer interaction bug: ActionList.Item's TrailingVisual wraps children in a VisualWrap span with pointer-events: none (trailing visuals are decorative-only by the library's own convention), which silently ate every click on the toggle until pointer-events: auto was added back on the button itself. Vitest covers the pinned-above-frecency/pin-order/dropped-stale-id/ no-mutation cases; quick-panel.spec.ts gained a full pin-sorts-above-frecency -> unpin-reverts -> persists-across-reload e2e case. Claude-Session: https://claude.ai/code/session_018pkViCNAuZp2vBv2K9AbUh Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pinnedWorkflowIds: string[]onshared/store.ts's existing persisted store (localStorage tier, same pattern as goal 0033'sactiveWorkTabKey), with atogglePinnedWorkflowaction.app/workflowFrecency.tsgainssortWorkflowsByPinnedAndFrecency, partitioning pinned rows (in pin order) above the existing frecency-sorted unpinned tail — reusessortWorkflowsByFrecencyrather than a new algorithm.PinIcontoggle on both the Quick Panel's and the ⌘K palette's workflow rows: muted outline unpinned, accent-colored once pinned.ActionList.Item'sTrailingVisualwraps children in aVisualWrapspan withpointer-events: none(trailing visuals are decorative-only by the library's own convention) — silently ate every click on the toggle untilpointer-events: autowas added back on the button.Test plan
npx tsc --noEmitnpm run lint(0 errors, pre-existing warnings only)npx vitest run(251/251, including new pinned-sort cases)npm run boundaries(0 violations)npx playwright test e2e/quick-panel.spec.ts e2e/command-palette.spec.ts(10/10, including the new pin→sort→unpin→reload-persists case)🤖 Generated with Claude Code
https://claude.ai/code/session_018pkViCNAuZp2vBv2K9AbUh