build(deps-dev): Bump eslint from 9.39.5 to 10.8.1 in /frontend - #4
Closed
dependabot[bot] wants to merge 1 commit into
Closed
build(deps-dev): Bump eslint from 9.39.5 to 10.8.1 in /frontend#4dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.5 to 10.8.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.5...v10.8.1) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.8.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/frontend/eslint-10.8.1
branch
from
August 12, 2026 02:03
b7cdcad to
0ecbd2d
Compare
8 tasks
alicoding
added a commit
that referenced
this pull request
Aug 12, 2026
/#7) (#30) Bundled together, not sequential: react-hooks 5.2.0 only peer-supports eslint up to ^9.0.0, so eslint 10 required react-hooks 7.1.1 in the same migration (confirmed via npm view peerDependencies before starting, per Dependabot #4/#7 both being red). react-hooks 6.x/7.x folded the React Compiler's lint rules into `recommended`, surfacing real new violations, triaged rule-by-rule: - preserve-caught-error (new eslint 10 core rule): two e2e fixture throws now attach `cause` to the original error. - no-useless-assignment (new eslint 10 core rule): a genuinely dead initializer in SchemaIntake's detect(). - react-hooks/immutability: QuickPanel's refreshFrecency/openMain moved above the effects that reference them (order-only, same runtime closures). - react-hooks/refs, react-hooks/purity: two legitimate false positives (a headless-hook ref-spread idiom in Tabs.tsx, an intentional Date.now() read in a relative-time badge) documented with disable-line comments. - react-hooks/set-state-in-effect: tuned off project-wide in eslint.config.js -- flags an established, deliberate 15-instance reset-state-on-id-change idiom across the codebase; rewriting all 15 call sites is real behavioral refactor work well beyond this bump's scope, so this follows .golangci.yml's own "tune when defaults fight house style" precedent instead of scattering 15 disable-line comments or silently regressing behavior. Also bumped @eslint/js to match eslint 10's flat-config recommended preset. typescript-eslint (8.66+) and eslint-plugin-react-refresh (0.5.3) already peer-support eslint 10, so neither needed a bump. Full local suite green: eslint, tsc, boundaries, vitest (227/227), frontend build, go vet, go build (desktop+server), file-loc-limit, rules-frontmatter, root-file-naming. Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Looks like eslint is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/frontend/eslint-10.8.1
branch
August 12, 2026 20:11
alicoding
added a commit
that referenced
this pull request
Aug 13, 2026
/#7) Bundled together, not sequential: react-hooks 5.2.0 only peer-supports eslint up to ^9.0.0, so eslint 10 required react-hooks 7.1.1 in the same migration (confirmed via npm view peerDependencies before starting, per Dependabot #4/#7 both being red). react-hooks 6.x/7.x folded the React Compiler's lint rules into `recommended`, surfacing real new violations, triaged rule-by-rule: - preserve-caught-error (new eslint 10 core rule): two e2e fixture throws now attach `cause` to the original error. - no-useless-assignment (new eslint 10 core rule): a genuinely dead initializer in SchemaIntake's detect(). - react-hooks/immutability: QuickPanel's refreshFrecency/openMain moved above the effects that reference them (order-only, same runtime closures). - react-hooks/refs, react-hooks/purity: two legitimate false positives (a headless-hook ref-spread idiom in Tabs.tsx, an intentional Date.now() read in a relative-time badge) documented with disable-line comments. - react-hooks/set-state-in-effect: tuned off project-wide in eslint.config.js -- flags an established, deliberate 15-instance reset-state-on-id-change idiom across the codebase; rewriting all 15 call sites is real behavioral refactor work well beyond this bump's scope, so this follows .golangci.yml's own "tune when defaults fight house style" precedent instead of scattering 15 disable-line comments or silently regressing behavior. Also bumped @eslint/js to match eslint 10's flat-config recommended preset. typescript-eslint (8.66+) and eslint-plugin-react-refresh (0.5.3) already peer-support eslint 10, so neither needed a bump. Full local suite green: eslint, tsc, boundaries, vitest (227/227), frontend build, go vet, go build (desktop+server), file-loc-limit, rules-frontmatter, root-file-naming. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
…ent registry semantics Three independent, verified changes (goal-scoped work, tasks #1/#4/#6): - task build/package/build:server now echo their real output path on success, and task run's darwin/linux/windows tasks gained a missing deps: on build:native -- previously `task run` assumed a binary already existed and would fail on a fresh clone, despite its name and summary implying it's a standalone build+launch command (run:server already had this right; desktop run: didn't). - internal/adapters/execution.New now takes a full DSN (databaseURL) instead of hardcoding "sqlite:"+dbPath internally. DBOS itself already accepts Postgres/CockroachDB DSNs; the scheme choice moves to the caller (main.go), which now reads MILL_EXECUTION_DATABASE_URL as an override, falling back to the existing MILL_EXECUTION_DB_PATH/default sqlite path unchanged. A regulated deployment needing an externally managed audit database gets there via config, not an adapter rewrite. - The three ADR-0006/ADR-0015 self-registration registries (RegisterNodeType, RegisterTrigger, RegisterAuthStrategy) have two different duplicate-key behaviors (panic vs silent overwrite), undocumented until now. Recorded on all three functions plus a SPEC.md cross-reference -- not a decision, just making a real, previously-invisible inconsistency visible. Verified: go vet, golangci-lint (0 issues), go test ./internal/... -race -cover (all pass), go build for both desktop and CGO_ENABLED=0-equivalent server tags, check-loc.sh, check-rules-frontmatter.sh. Frontend checks skipped -- zero frontend files touched, matching lefthook.yml's own glob scoping. Taskfile run: fix verified via `task --dry` (confirms build:native now runs before launch) plus one live task package run earlier in the session; full live task run execution was blocked by resource contention with an unrelated, pre-existing `task dev` session on this machine and deliberately not forced. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
Was 12 direct package-function call sites in package main (Set/Get/ Delete), no interface, no injection -- unlike settings.Store, which is already a real port every ConfigureService/CompositionService/ TriggerService consumer depends on rather than the concrete KVStore type. Confirmed by the architecture research this session: this was the one genuine adapter-shape gap among the three adapters checked (settings.Store already worked as advertised; execution's DSN parameterization, task #4, needed a one-line fix instead of this). credential.Store mirrors settings.Store's exact shape (small interface, a New() constructor callers depend on instead of the concrete type) -- the one difference is go-keyring itself is package-function-based with no existing struct to satisfy the interface structurally, so a small keyringStore{} adapter type exists solely to give those functions a method set. ConfigureService gained a `credentials credential.Store` field, threaded through NewConfigureService's third parameter from main.go (credential.New()). All 12 production call sites across configureservice_requestauth.go, configureservice_requesttest.go, and configureservice_builtin.go now go through c.credentials instead of the package directly, closing the actual gap: package main's tests (1000+ lines, wired into CI/Lefthook by task #5 this same session) were previously the only thing exercising this code path indirectly through keyring.MockInit() -- now the seam itself is real and independently testable. Verified: go vet, golangci-lint (0 issues), ls_lint, go test . ./internal/... -race -cover (root package unchanged at 57.2% coverage, credential adapter now 100%), go build for both desktop and server tags. All 14 test call sites across three _test.go files updated to pass credential.New() -- still exercises the real keyring, backed by the same keyring.MockInit() TestMain already covered the whole package main test binary with, so no test behavior changed, only how the dependency reaches the code under test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
/#7) (#30) Bundled together, not sequential: react-hooks 5.2.0 only peer-supports eslint up to ^9.0.0, so eslint 10 required react-hooks 7.1.1 in the same migration (confirmed via npm view peerDependencies before starting, per Dependabot #4/#7 both being red). react-hooks 6.x/7.x folded the React Compiler's lint rules into `recommended`, surfacing real new violations, triaged rule-by-rule: - preserve-caught-error (new eslint 10 core rule): two e2e fixture throws now attach `cause` to the original error. - no-useless-assignment (new eslint 10 core rule): a genuinely dead initializer in SchemaIntake's detect(). - react-hooks/immutability: QuickPanel's refreshFrecency/openMain moved above the effects that reference them (order-only, same runtime closures). - react-hooks/refs, react-hooks/purity: two legitimate false positives (a headless-hook ref-spread idiom in Tabs.tsx, an intentional Date.now() read in a relative-time badge) documented with disable-line comments. - react-hooks/set-state-in-effect: tuned off project-wide in eslint.config.js -- flags an established, deliberate 15-instance reset-state-on-id-change idiom across the codebase; rewriting all 15 call sites is real behavioral refactor work well beyond this bump's scope, so this follows .golangci.yml's own "tune when defaults fight house style" precedent instead of scattering 15 disable-line comments or silently regressing behavior. Also bumped @eslint/js to match eslint 10's flat-config recommended preset. typescript-eslint (8.66+) and eslint-plugin-react-refresh (0.5.3) already peer-support eslint 10, so neither needed a bump. Full local suite green: eslint, tsc, boundaries, vitest (227/227), frontend build, go vet, go build (desktop+server), file-loc-limit, rules-frontmatter, root-file-naming. Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eslint from 9.39.5 to 10.8.1.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
c049dc310.8.1a3f7826Build: changelog update for 10.8.118eb0a7fix: prevent ASI hazard inno-unused-labelsautofix (#21173)0a14800chore: update github/codeql-action action to v4.37.4 (#21196)7d0cbf8docs: Update README05adcb1test: fix failing ecosystem test foreslint-plugin-unicorn(#21191)5611035test: add error locations info tono-void(#21185)ee47333ci: bump github/codeql-action from 4 to 4.37.3 (#21176)f131c03chore: improve ecosystem test failure reporting (#20937)0a05812docs: add missing backticks tono-duplicate-imports.js(#21183)