fix: allow CHANGELOG.md at the repo root - #360
Merged
Merged
Conversation
release-please generates CHANGELOG.md at the root on every release PR, and the root allowlist never included it -- so every release PR failed root-file-naming, which is a required check, and could never merge. Release 0.5.0 was blocked on exactly this. The release branch is the one branch that cannot resolve this by moving the file elsewhere, so the allowlist is the right place to fix it. Added deliberately with its reason, per the root-layout rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.5.0 (#319) could never merge, and the reason was our own gate.
release-please generates
CHANGELOG.mdat the repo root on every release PR. The root allowlist in.ls-lint.ymldoesn't include it, soroot-file-namingfails — and that's a required check feedingci-gate. Every release PR would hit this, not just this one.Worth noting how it stayed hidden: the release PR is authored by the
github-actionsbot, so its CI runs sit ataction_requiredand never execute. The PR showed "blocked" with every visible check green, which reads like a mystery rather than a failure. Approving the run surfaced the actual error immediately.The release branch is the one branch that can't resolve this by moving the file somewhere else, so the allowlist is the correct place to fix it. Added deliberately with its reason inline, per the root-layout rule that says a new root file is a considered decision rather than a quiet regex tweak.
Verified locally:
ls_lintexits 0 with the change.🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd