fix: bridge smoke waits for node position stability before clicking (goal 0107 CI follow-up) - #243
Merged
Merged
Conversation
…goal 0107 CI follow-up) First CI run of the calibrated registry: 5/6 green on the hosted runner; the one failure was the commit check's select click landing mid-fitView-animation -- the click dispatches to where the card WAS and selects nothing (the same stale-coordinate class the e2e suite's clickFrameGutter helper exists for). waitForNodeStable polls the card's bounding rect across consecutive samples before the commit and ring checks click; scripted fakes updated. 3/3 local runs green. Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First CI outcome of the calibrated registry (goal 0107 scope item 2): 5/6 green on the hosted macOS runner — badge, window shape, board render, selection ring, and sticky flip all pass. The one failure was
note-card-commit-interaction's select click racing the board's fitView animation — the click lands where the card was mid-animation and selects nothing, the same stale-coordinate class the Playwright suite'sclickFrameGutterhelper exists for (it also explained the 1-in-3 local flake observed during calibration).waitForNodeStablepolls the card's bounding rect until two consecutive samples agree before the commit and ring checks dispatch their clicks. 3/3 consecutive local runs green; scripted-fake unit tests updated (fast-pathed so negative subtests don't wait out the poll).Job stays non-required until a CI track record accrues on this.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd