fix(api-client): add default settings and fix workflow update method - #1
Open
vuralozsen wants to merge 1 commit into
Open
fix(api-client): add default settings and fix workflow update method#1vuralozsen wants to merge 1 commit into
vuralozsen wants to merge 1 commit into
Conversation
## Problem 1. createWorkflow fails with 'request/body must have required property settings' when settings parameter is not provided 2. updateWorkflow fails because PATCH method doesn't include all required fields, forcing users to delete and recreate workflows instead of updating them ## Solution ### createWorkflow Fix - Added automatic default settings when not provided: - executionOrder: 'v1' - saveManualExecutions: true - callerPolicy: 'workflowsFromSameOwner' ### updateWorkflow Fix - Changed approach: now fetches existing workflow first - Merges user updates with existing workflow data - Uses PUT method instead of PATCH for full replacement - Ensures all required fields are always present ## Testing - Verified workflow creation without settings parameter - Verified workflow update (name change) without recreating - Both operations now properly register workflows in n8n Fixes workflow registration issues when using MCP tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
createWorkflow Fix
updateWorkflow Fix
Testing
Fixes workflow registration issues when using MCP tool