Skip to content

feat: add field-aware fallback for AI shopping - #225

Open
lgqfhwy wants to merge 13 commits into
masterfrom
feat/aishopping-field-aware-fallback
Open

feat: add field-aware fallback for AI shopping#225
lgqfhwy wants to merge 13 commits into
masterfrom
feat/aishopping-field-aware-fallback

Conversation

@lgqfhwy

@lgqfhwy lgqfhwy commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Enable the strict field-aware shopping Tool contract for every configured output language instead of gating it to English.
  • Require non-English Planners to translate the complete positive shopping intent, product type, attributes, and exclusions into English catalog terms.
  • Preserve one AND Tool Call per request; default-first and multi-field zero-hit fallback remain deterministic Go Recall behavior.
  • Keep the JSON Schema strict while narrowly accepting a scalar string keywords value as its unambiguous one-element array form.
  • Clarify top-level versus nested HA3 errors decoding without changing response semantics.
  • Keep legacy behavior unchanged when field-aware fields are not configured.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread service/recall/ha3_chat_recall.go
Comment thread service/recall/ha3_chat_recall.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread service/recall/ha3_chat_multi_field.go
Comment thread service/recall/ha3_chat_recall.go
Comment thread service/recall/ha3_chat_recall.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread service/aishopping/agent_loop.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread persist/fs/featurestore.go
Comment thread persist/fs/featurestore.go
Comment thread service/aishopping/agent_loop.go
Comment thread service/aishopping/citation.go
Comment thread service/recall/ha3_chat_recall.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread persist/fs/featurestore.go
@lgqfhwy
lgqfhwy marked this pull request as ready for review August 10, 2026 06:55

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread persist/fs/featurestore.go
Comment thread persist/fs/featurestore.go
Comment thread service/aishopping/agent_loop.go
Comment thread service/aishopping/citation.go
Comment thread service/recall/ha3_chat_distinct.go
Comment thread service/recall/ha3_chat_recall.go
Comment thread service/recall/ha3_chat_recall.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread persist/fs/featurestore.go
Comment thread persist/fs/featurestore_test.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Comment thread service/aishopping/citation.go
Comment thread service/aishopping/orchestrator.go
Comment thread service/aishopping/orchestrator.go
Comment thread service/aishopping/suggestion_coordinator.go
Comment thread web/search_suggestion_controller.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant