fix(review): honor lower max-tools overrides - #1118
Open
DreamZhongJu wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s). |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
review --max-toolsapply validated positive values exactly.On current
main, values from 1 to 49 are normalized to 50, but the shared template loader only applies values greater than the template default of 100. As a result, values from 50 to 99 are accepted but silently ignored.This change:
--max-toolsis0;scancommand behavior unchanged;max_tool_request_timesin the run manifest;For example,
review --max-tools 50now uses 50 rounds instead of silently retaining 100.Testing
go test -race -count=1 ./...go test -p=1 -count=1 ./...go vet ./...go run scripts/verify-english-only.goFixes #935
Related: #936 was closed without being merged.