Skip to content

chore: regen fullstack to incorporate other template changes#48

Merged
neilcampbell merged 1 commit into
mainfrom
fix/adjust-default-deploy-settings
Jul 18, 2025
Merged

chore: regen fullstack to incorporate other template changes#48
neilcampbell merged 1 commit into
mainfrom
fix/adjust-default-deploy-settings

Conversation

@neilcampbell

Copy link
Copy Markdown
Contributor

No description provided.

@CiottiGiorgio CiottiGiorgio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have one comment that is not required to be addressed in this PR.

python-dotenv = "^1.0.0"
algorand-python = "^2.0.0"
algorand-python-testing = "^0.4.0"
algorand-python-testing = "~0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is a good way to enforce the constraint that a specific version of the language stubs should be installed together with a specific version of the testing library.

Would it work if we added an optional dependency group to the stubs called testing-stubs that requires at least a compatible version of algorand-python-testing so that, if you install the language with the testing-stubs option, you get at least a compatible version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's an interesting idea.
Typically the install happens via algokit boostrap all, which doesn't have support for passing optional group info and is also executed as an optional step when running algokit init. It's possible to incorporate this, however it'd need some changes.

@neilcampbell
neilcampbell merged commit 56ebc4b into main Jul 18, 2025
1 check passed
@neilcampbell
neilcampbell deleted the fix/adjust-default-deploy-settings branch July 18, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants