This repository was archived by the owner on Jul 27, 2020. It is now read-only.
Feat: add 4 features #13
Draft
TomKlotzPro wants to merge 139 commits into
Draft
Conversation
Add boilerplate
Add Style CI
…ate documentation for tests
TomKlotzPro
force-pushed
the
feat/first
branch
12 times, most recently
from
33e6128 to
6f65ab2
Compare
chloelbn
reviewed
Jul 3, 2019
chloelbn
reviewed
Jul 3, 2019
TomKlotzPro
force-pushed
the
feat/first
branch
3 times, most recently
from
e642a2b to
889256a
Compare
chloelbn
reviewed
Jul 3, 2019
Contributor
Author
|
Until we don't take hand on API Key Dealer Travis CI. Travis will fail. cc @nunomaduro |
TomKlotzPro
force-pushed
the
feat/first
branch
3 times, most recently
from
8124c64 to
ff31640
Compare
|
@TomKlotzPro Let's discuss the api key dealer tomorrow. |
nunomaduro
suggested changes
Jul 9, 2019
nunomaduro
left a comment
nunomaduro
left a comment
There was a problem hiding this comment.
Very minor details, overall the pull request is impressive.
TomKlotzPro
force-pushed
the
feat/first
branch
2 times, most recently
from
cc185af to
09820f3
Compare
Fix : generate settings test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is related to this proposal.
What it changes
This helper will add 4 features :