fix(frontend): defer review list update to avoid NG0100#534
Merged
Conversation
- close expense dialog with a signal instead of mutating list inside close callback - defer removeExpenseFromList via setTimeout so it runs after change detection - centralize empty-close in removeExpenseFromList
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ExpressionChangedAfterItHasBeenCheckedError in statement review dialog. List mutation ran inside the same change detection cycle that closed the child dialog, so the list only refreshed after the next user action. Now the mutation is deferred to the next tick and the empty-close is centralized.