fix(frontend): clear import state after save and close#528
Merged
Conversation
- use instanceof Expense check instead of truthy to detect saved expense - auto-close review dialog when last expense is saved individually - handle DIALOG_ACTION_CLOSE in processImport to clear or reload storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two related bugs in bank statement import flow:
Transaction stays in list after save —
expenseDialog.onCloseused truthy check (!savedExpense) which could pass for non-Expense values. Changed toinstanceof Expensefor reliable detection.Pending import shown after all saved individually — when last expense was saved one-by-one, dialog closed with
DIALOG_ACTION_CLOSEbutprocessImport()had no handler for that action, so localStorage was never cleared.Fix
statement-review-dialog: useinstanceof Expensecheck; auto-close dialog when last expense is savedstatement-import.service: importDIALOG_ACTION_CLOSEconstant and handle it — clear storage if empty, reload if not